cryptoe commented on code in PR #17674:
URL: https://github.com/apache/druid/pull/17674#discussion_r1968864978
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3Utils.java:
##########
@@ -96,6 +96,9 @@ public boolean apply(Throwable e)
// This can happen sometimes when AWS isn't able to obtain the
credentials for some service:
// https://github.com/aws/aws-sdk-java/issues/2285
return true;
+ } else if (e instanceof InterruptedException) {
+ Thread.interrupted(); // Clear interrupted state and not retry
Review Comment:
Why do we need to clear the interrupted flag.
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3TransferConfig.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.storage.s3;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+
+import javax.validation.constraints.Min;
+
+/**
+ */
+public class S3TransferConfig
+{
+ @JsonProperty
+ private boolean useTransferManager = true;
Review Comment:
Could you please update druid docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
