suraj-goel commented on code in PR #17674:
URL: https://github.com/apache/druid/pull/17674#discussion_r1969020003


##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3Utils.java:
##########
@@ -96,6 +96,9 @@ public boolean apply(Throwable e)
         // This can happen sometimes when AWS isn't able to obtain the 
credentials for some service:
         // https://github.com/aws/aws-sdk-java/issues/2285
         return true;
+      } else if (e instanceof InterruptedException) {
+        Thread.interrupted(); // Clear interrupted state and not retry

Review Comment:
   The intention is to gracefully stop the retry operations. 
   Although, The flag would already be cleared when the InterruptedException is 
thrown.
   
   Let me know if your suggestion is to modify it.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to