ashwintumma23 commented on code in PR #17744:
URL: https://github.com/apache/druid/pull/17744#discussion_r1970728392
##########
sql/src/main/java/org/apache/druid/sql/SqlExecutionReporter.java:
##########
@@ -101,14 +101,18 @@ public void emit()
// Note: the dimension is "dataSource" (sic), so we log only the SQL
resource
// actions. Even here, for external tables, those actions are not
always
// datasources.
- metricBuilder.setDimension(
- "dataSource",
- stmt.authResult.sqlResourceActions
- .stream()
- .map(action -> action.getResource().getName())
- .collect(Collectors.toList())
- .toString()
- );
+ String dataSourcesResourceNames = stmt.authResult.sqlResourceActions
+ .stream()
+ .map(action -> action.getResource().getName())
+ .collect(Collectors.toList())
+ .toString();
Review Comment:
Hi @kgyrtkirk ,
That's right, `setDimension(String dim, Object value)` can accept a `List`
as well.
About fixing it in the `PrometheusEmitter`: Initially, even I started with
the same thought process, but later realized that the issue impacts all the
emitters. A few examples (Prometheus, Kafka, Logging) cited in
https://github.com/apache/druid/issues/17743 . Hence, decided to perform the
string clean up operation here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
