kgyrtkirk commented on code in PR #17744:
URL: https://github.com/apache/druid/pull/17744#discussion_r1971152117
##########
sql/src/main/java/org/apache/druid/sql/SqlExecutionReporter.java:
##########
@@ -101,14 +101,18 @@ public void emit()
// Note: the dimension is "dataSource" (sic), so we log only the SQL
resource
// actions. Even here, for external tables, those actions are not
always
// datasources.
- metricBuilder.setDimension(
- "dataSource",
- stmt.authResult.sqlResourceActions
- .stream()
- .map(action -> action.getResource().getName())
- .collect(Collectors.toList())
- .toString()
- );
+ String dataSourcesResourceNames = stmt.authResult.sqlResourceActions
+ .stream()
+ .map(action -> action.getResource().getName())
+ .collect(Collectors.toList())
+ .toString();
Review Comment:
wow; didn't know about that - then you might want to fix the handling of
when the passed value is `List` in the builder to deliver it for all cases -
and not just for this one case?
note: I wonder how the case when the list has a "," in it should be
handled...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
