adarshsanjeev commented on code in PR #17775:
URL: https://github.com/apache/druid/pull/17775#discussion_r1984563012


##########
server/src/test/java/org/apache/druid/server/coordination/SegmentBootstrapperCacheTest.java:
##########
@@ -219,12 +219,12 @@ public void testLoadLocalCache() throws IOException, 
SegmentLoadingException
 
     // Make sure adding segments beyond allowed size fails
     DataSegment newSegment = TestSegmentUtils.makeSegment("test", 
"new-segment", SEGMENT_SIZE);
-    loadDropHandler.addSegment(newSegment, null);
+    loadDropHandler.addSegment(newSegment, null, 
SegmentLoadDropHandler.SegmentLoadingMode.NORMAL);
     
Assert.assertFalse(segmentAnnouncer.getObservedSegments().contains(newSegment));
 
     // Clearing some segment should allow for new segments
-    loadDropHandler.removeSegment(expectedSegments.get(0), null, false);
-    loadDropHandler.addSegment(newSegment, null);
+    loadDropHandler.removeSegment(expectedSegments.get(0), null, false, 
SegmentLoadDropHandler.SegmentLoadingMode.NORMAL);
+    loadDropHandler.addSegment(newSegment, null, 
SegmentLoadDropHandler.SegmentLoadingMode.NORMAL);

Review Comment:
   This change was unnecessary, from before I added the older variant back. 
Reverted this change. Thanks for catching this!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to