kfaraz commented on code in PR #17830: URL: https://github.com/apache/druid/pull/17830#discussion_r2011542394
########## server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java: ########## @@ -57,7 +58,7 @@ * Responsible for loading and dropping of segments by a process that can serve segments. */ @ManageLifecycle -public class SegmentLoadDropHandler implements DataSegmentChangeHandler Review Comment: It wouldn't make sense to modify the interface since a `DataSegmentChangeRequest` itself is not aware of the loading mode. Having `SegmentLoadDropHandler` implement the handler interface doesn't seem to serve any real purpose, since we are already creating a separate handler inside `processRequest` method. That handler then calls the outside `add` or `remove` methods. So I decided to just get rid of that interface. For now, this seemed the cleanest approach. We can add it back in the future, if needed. Please let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
