kfaraz commented on code in PR #17830:
URL: https://github.com/apache/druid/pull/17830#discussion_r2011543336
##########
server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java:
##########
@@ -141,12 +143,15 @@ public Map<String, SegmentRowCountDistribution>
getRowCountDistributionPerDataso
return segmentManager.getRowCountDistribution();
}
- @Override
- public void addSegment(DataSegment segment, @Nullable
DataSegmentChangeCallback callback)
+ public void addSegment(
Review Comment:
Replied to the other comment.
No point adding two methods since only one of them is ever meant to be used
in practice.
The contract of `SegmentLoadDropHandler` can probably be cleaned up further
by making `addSegment` and `removeSegment` private. But that didn't seem
necessary now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
