clintropolis opened a new pull request, #17866:
URL: https://github.com/apache/druid/pull/17866
### Description
changes:
* Moved projection dimension initialization into `OnHeapAggregateProjection`
instead of being done externally
* Fix projection aggregations to work properly for rollup base tables with
the same aggregations (swap out projection agg with base table agg to build the
projection from the raw input row)
* Added validation for projection aggregations to ensure they either
reference a base table aggregation (being a combining agg of some base table
agg) or they reference a base table dimension(s)
* Added validation for projection virtual columns to ensure they reference a
base table dimension
* Tests for rollup projections
* Tests for `OnHeapAggregationProjection` validations
#### Release note
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
