jtuglu-netflix commented on PR #17847:
URL: https://github.com/apache/druid/pull/17847#issuecomment-2777651706

   > @jtuglu-netflix , thanks for the PR.
   > 
   > I am not sure I see how the new metrics add any value. The metric 
`ingest/events/messageGap` is already emitted with `taskId` as a dimension. You 
could just look at the interval in question and find the max, avg, min values 
across task IDs and even for a single task ID.
   
   Adding to the above, if you have gaps of 5,4,3,2,1 in sequence (with 
timestamps increasing) we would only emit 1. That's not a great indicator of 
how big (on avg) the gap was and/or any min/max values. To get a better view of 
such things, one would need to significantly lower the emission period, but 
this has its limits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to