maytasm commented on code in PR #17847:
URL: https://github.com/apache/druid/pull/17847#discussion_r2051609982
##########
server/src/main/java/org/apache/druid/segment/realtime/SegmentGenerationMetrics.java:
##########
@@ -105,6 +123,14 @@ public void setSinkCount(long sinkCount)
this.sinkCount.set(sinkCount);
}
+ public void reportMessageGap(final long messageGap)
+ {
+ final long numEvent = this.numMessageGap.incrementAndGet();
+ this.avgMessageGap.getAndUpdate(oldAvg -> oldAvg + ((messageGap - oldAvg)
/ numEvent));
Review Comment:
Won't it be more efficient to just keep a running sum? Then only calculate
the avg using numEvent when we get the average
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
