Akshat-Jain commented on code in PR #17876:
URL: https://github.com/apache/druid/pull/17876#discussion_r2028994159
##########
.github/workflows/ci.yml:
##########
@@ -61,11 +56,26 @@ jobs:
truncate_stack_traces: false
reporting-jacoco-coverage-failures:
- name: "report-jacoco-coverage-failures"
+ name: "coverage-jacoco"
needs: run-unit-tests
uses: ./.github/workflows/worker.yml
if: ${{ !contains( github.event.pull_request.labels.*.name, 'jacoco:skip')
}}
with:
script: .github/scripts/create-jacoco-coverage-report.sh
artifacts_to_download: "unit-test-reports-*"
- key: "jacoco-coverage-report"
+ key: "coverage-jacoco"
+
+ run-unit-tests-all-jdk:
+ needs: test-report
+ name: "unit tests(all jdk)"
+ if: ${{ !cancelled() && ( contains(
github.event.pull_request.labels.*.name, 'tests:all-jdk') || github.event_name
== 'push' ) }}
+ strategy:
+ fail-fast: false
+ matrix:
+ pattern: [ "L*,Q*,W*", "C*,E*", "B*,O*,S*,X*,Y*,Z*", "A*,G*,R*",
"M*,P*,V*", "D*,J*,K*", "F*,H*,U*", "I*,N*,T*"]
+ jdk: [ "11", "21.0.4" ]
+ uses: ./.github/workflows/worker.yml
+ with:
+ script: .github/scripts/run-unit-tests.sh -Dtest='${{ matrix.pattern }}'
-fae
Review Comment:
Is the intention to not skip failures, since this isn't used for jacoco
coverage purposes? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
