Akshat-Jain commented on code in PR #17876:
URL: https://github.com/apache/druid/pull/17876#discussion_r2030542857
##########
.github/workflows/ci.yml:
##########
@@ -61,11 +56,26 @@ jobs:
truncate_stack_traces: false
reporting-jacoco-coverage-failures:
- name: "report-jacoco-coverage-failures"
+ name: "coverage-jacoco"
needs: run-unit-tests
uses: ./.github/workflows/worker.yml
if: ${{ !contains( github.event.pull_request.labels.*.name, 'jacoco:skip')
}}
with:
script: .github/scripts/create-jacoco-coverage-report.sh
artifacts_to_download: "unit-test-reports-*"
- key: "jacoco-coverage-report"
+ key: "coverage-jacoco"
+
+ run-unit-tests-all-jdk:
Review Comment:
Thanks!
The link you shared offline
(https://github.com/kgyrtkirk/druid/actions/runs/14238055744/job/39903138680)
had the 11 and 21.0.4 runs also upload reports to the artifact. Is that an
outdated run?
Can you confirm that only the JDK 17 unit test jobs would be uploading
reports to artifacts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
