kfaraz commented on code in PR #17816: URL: https://github.com/apache/druid/pull/17816#discussion_r2007100357
########## server/src/main/java/org/apache/druid/indexing/overlord/SegmentPublishResult.java: ########## @@ -34,22 +34,14 @@ import java.util.Set; /** - * Result of an operation that attempts to publish segments. Indicates the set of segments actually published - * and whether or not the transaction was a success. - * - * If "success" is false then the segments set will be empty. - * - * It's possible for the segments set to be empty even if "success" is true, since the segments set only - * includes segments actually published as part of the transaction. The requested segments could have been - * published by a different transaction (e.g. in the case of replica sets) and this one would still succeed. + * Result of a segment publish operation. */ public class SegmentPublishResult { + private final boolean canRetry; private final Set<DataSegment> segments; private final boolean success; Review Comment: Sure, will do 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org