adarshsanjeev commented on code in PR #17863:
URL: https://github.com/apache/druid/pull/17863#discussion_r2032428928
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/StrategicSegmentAssigner.java:
##########
@@ -446,7 +446,8 @@ private int dropReplicas(
for (ServerHolder server : eligibleServers) {
if (server.isDecommissioning()) {
eligibleDyingServers.add(server);
- } else {
+ } else if (!server.isUnmanaged()) {
Review Comment:
1. Is `allManagedServers` required? I don't see any use current use case of
`getAllServers()` which should be replaced.
2. Should we add a different metric CLONE_COUNT instead of HISTORICAL_COUNT
for clone servers to track capacity better? Should clones affect
`tier/total/capacity`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
