kfaraz commented on code in PR #17863:
URL: https://github.com/apache/druid/pull/17863#discussion_r2032434652
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/StrategicSegmentAssigner.java:
##########
@@ -446,7 +446,8 @@ private int dropReplicas(
for (ServerHolder server : eligibleServers) {
if (server.isDecommissioning()) {
eligibleDyingServers.add(server);
- } else {
+ } else if (!server.isUnmanaged()) {
Review Comment:
1. There are two usages of `allServers()` that need to be removed. One is
`StrategicSegmentAssigner.broadcast()`. The other is in `UnloadUnusedSegments`.
2. We can leave historical count metric as is. But you can emit a clone
count in addition to that to track the number of clones. The clones should not
count towards the tier capacity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
