adarshsanjeev commented on code in PR #17899:
URL: https://github.com/apache/druid/pull/17899#discussion_r2051946897
##########
server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java:
##########
@@ -607,7 +607,7 @@ private <T> QueryRunner<T> decorateClusterRunner(Query<T>
query, QueryRunner<T>
* @param parentQueryResourceId Parent Query's Query Resource ID
* @return DataSource populated with the subqueries
*/
- private DataSource generateSubqueryIds(
+ public static DataSource generateSubqueryIds(
Review Comment:
The CachingClusteredClient benchmark was broken as subquery Ids were not
present in the queries it was running. Let me annotate it with a "visible for
testing" for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
