adarshsanjeev commented on code in PR #17899: URL: https://github.com/apache/druid/pull/17899#discussion_r2052057334
########## server/src/main/java/org/apache/druid/client/selector/HistoricalFilter.java: ########## @@ -0,0 +1,39 @@ +package org.apache.druid.client.selector; + +import com.google.common.collect.ImmutableSet; +import it.unimi.dsi.fastutil.ints.Int2ObjectRBTreeMap; +import org.apache.druid.client.QueryableDruidServer; + +import java.util.Set; +import java.util.function.Function; +import java.util.function.Supplier; +import java.util.stream.Collectors; + +public class HistoricalFilter implements Function<Int2ObjectRBTreeMap<Set<QueryableDruidServer>>, Int2ObjectRBTreeMap<Set<QueryableDruidServer>>> Review Comment: Changing the function to Set has some issues, as mentioned in https://github.com/apache/druid/pull/17899#discussion_r2039275089. Regarding changing `DynamicConfigManager` to an implementation of `HistoricalFilter`, this means that the cloneQueryMode enum would need to be added as an additional argument to each function in ServerSelector. Is this still the cleaner option? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
