clintropolis commented on code in PR #17894:
URL: https://github.com/apache/druid/pull/17894#discussion_r2056549548
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -852,11 +862,16 @@ public PlannerFixture(
new DruidHookDispatcher()
);
componentSupplier.finalizePlanner(this);
- this.statementFactory = QueryFrameworkUtils.createSqlStatementFactory(
+ final SqlToolbox toolbox = new SqlToolbox(
framework.engine,
plannerFactory,
- authConfig
+ new ServiceEmitter("dummy", "dummy", new NoopEmitter()),
+ new NoopRequestLogger(),
+ QueryStackTests.DEFAULT_NOOP_SCHEDULER,
+ new DefaultQueryConfig(ImmutableMap.of()),
+ new SqlLifecycleManager()
Review Comment:
You want to bind the statement factory with like a different version of
`SqlStatementFactoryModule` that makes this instead of the regular one I guess
instead of making it here? I guess can do that, will look into it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
