clintropolis commented on code in PR #17894:
URL: https://github.com/apache/druid/pull/17894#discussion_r2056541599
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -852,11 +862,16 @@ public PlannerFixture(
new DruidHookDispatcher()
);
componentSupplier.finalizePlanner(this);
- this.statementFactory = QueryFrameworkUtils.createSqlStatementFactory(
+ final SqlToolbox toolbox = new SqlToolbox(
framework.engine,
plannerFactory,
- authConfig
+ new ServiceEmitter("dummy", "dummy", new NoopEmitter()),
+ new NoopRequestLogger(),
+ QueryStackTests.DEFAULT_NOOP_SCHEDULER,
+ new DefaultQueryConfig(ImmutableMap.of()),
+ new SqlLifecycleManager()
);
+ this.statementFactory = new TestMultiStatementFactory(toolbox,
framework.engine, plannerFactory);
Review Comment:
I can't really think of a use case outside of testing, and adding it to the
config would make it available in production too i think, which I can't think
of any legit uses there since I don't think we want to allow multi-statement
jdbc statements in the real world. What do you have in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
