clintropolis commented on code in PR #17899: URL: https://github.com/apache/druid/pull/17899#discussion_r2057654118
########## server/src/main/java/org/apache/druid/server/http/BrokerSyncStatus.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.http; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.druid.rpc.ServiceLocation; + +import java.util.Objects; + +public class BrokerSyncStatus Review Comment: nit: javadocs please ########## server/src/main/java/org/apache/druid/client/CachingClusteredClient.java: ########## @@ -126,11 +128,13 @@ public class CachingClusteredClient implements QuerySegmentWalker private final ForkJoinPool pool; private final QueryScheduler scheduler; private final ServiceEmitter emitter; + private final BrokerViewOfCoordinatorConfig brokerViewOfCoordinatorConfig; @Inject public CachingClusteredClient( QueryRunnerFactoryConglomerate conglomerate, TimelineServerView serverView, + BrokerViewOfCoordinatorConfig brokerViewOfCoordinatorConfig, Review Comment: why does `CachingClusteredClient` need this to just pass into `ServerSelector` instead of creating `ServerSelector` with it? And since we pass the query into `pick` anyway it seems like nothing here would have to change if we did that instead ########## server/src/main/java/org/apache/druid/client/ServerViewUtil.java: ########## @@ -42,17 +44,21 @@ public static List<LocatedSegmentDescriptor> getTargetLocations( TimelineServerView serverView, String datasource, List<Interval> intervals, - int numCandidates + int numCandidates, + HistoricalFilter historicalFilter, + CloneQueryMode cloneQueryMode ) { - return getTargetLocations(serverView, new TableDataSource(datasource), intervals, numCandidates); + return getTargetLocations(serverView, new TableDataSource(datasource), intervals, numCandidates, historicalFilter, cloneQueryMode); Review Comment: this also would only need `cloneQueryMode` if the config was already on `ServerSelector` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
