kfaraz commented on code in PR #17899: URL: https://github.com/apache/druid/pull/17899#discussion_r2063505364
########## processing/src/main/java/org/apache/druid/query/QueryContexts.java: ########## @@ -149,6 +150,7 @@ public class QueryContexts public static final boolean DEFAULT_ENABLE_JOIN_FILTER_PUSH_DOWN = true; public static final boolean DEFAULT_ENABLE_JOIN_FILTER_REWRITE = true; public static final boolean DEFAULT_ENABLE_JOIN_FILTER_REWRITE_VALUE_COLUMN_FILTERS = false; + public static final CloneQueryMode DEFAULT_CLONE_QUERY_MODE = CloneQueryMode.EXCLUDECLONES; Review Comment: Yeah, I see your point. The use case doesn't seem all that important, except maybe to ensure that segment remains available even when the source server flickers (but that is already handled by having 2 replicas). In fact, the `includeClones` mode might actually cause changes in query performance in a non-deterministic manner. Let's get rid of it for now. We can add it back if there seems to be a real need for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
