leventov commented on a change in pull request #7121: Prohibit
Throwables.propagate()
URL: https://github.com/apache/incubator-druid/pull/7121#discussion_r260016673
##########
File path:
indexing-hadoop/src/main/java/org/apache/druid/indexer/updater/HadoopConverterJob.java
##########
@@ -344,9 +343,7 @@ public DataSegment apply(final Path input)
}
}
catch (InterruptedException | ClassNotFoundException e) {
- RuntimeException exception = Throwables.propagate(e);
- throwable = exception;
- throw exception;
+ throw new RuntimeException(e);
Review comment:
It seems to me that this catching clause should be removed because the next
clause (catching `Throwable`) has code that should actually be called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
