kfaraz commented on code in PR #17847:
URL: https://github.com/apache/druid/pull/17847#discussion_r2066980701
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/stats/TaskRealtimeMetricsMonitor.java:
##########
@@ -132,6 +132,19 @@ public boolean doMonitor(ServiceEmitter emitter)
emitter.emit(builder.setMetric("ingest/events/messageGap", messageGap));
}
+ final long minMessageGap = metrics.minMessageGap();
+ final long maxMessageGap = metrics.maxMessageGap();
+ // Best-effort way to ensure parity amongst emitted metrics
+ if (metrics.isMessageGapAggStatsEnabled()) {
+ if (minMessageGap != Long.MAX_VALUE) {
+ emitter.emit(builder.setMetric("ingest/events/minMessageGap",
minMessageGap));
Review Comment:
If we use the impl suggested in [this
comment](https://github.com/apache/druid/pull/17847#discussion_r2066975828),
the overhead would be negligible I feel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
