jtuglu-netflix commented on code in PR #17847:
URL: https://github.com/apache/druid/pull/17847#discussion_r2066782035
##########
server/src/main/java/org/apache/druid/segment/realtime/SegmentGenerationMetrics.java:
##########
@@ -105,6 +123,14 @@ public void setSinkCount(long sinkCount)
this.sinkCount.set(sinkCount);
}
+ public void reportMessageGap(final long messageGap)
+ {
+ final long numEvent = this.numMessageGap.incrementAndGet();
+ this.avgMessageGap.getAndUpdate(oldAvg -> oldAvg + ((messageGap - oldAvg)
/ numEvent));
Review Comment:
> Just keep a AtomicDouble totalMessageGap (to avoid the overflow problem)
Afaik, this doesn't avoid the overflow problem. You can still have Double
overflow (will just wrap to infinity).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
