kgyrtkirk commented on code in PR #17895: URL: https://github.com/apache/druid/pull/17895#discussion_r2068590556
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/dart/controller/sql/DartSqlEngine.java: ########## @@ -70,6 +72,21 @@ public class DartSqlEngine implements SqlEngine private final DartControllerConfig controllerConfig; private final ExecutorService controllerExecutor; + @Inject Review Comment: `DartControllerModule#makeSqlStatementFactory` is a `@LazySingleton`; so it might have worked as expected - but added `@LazySingleton` as that should be the right mode for this class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
