cryptoe commented on code in PR #17895:
URL: https://github.com/apache/druid/pull/17895#discussion_r2068648144
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -124,7 +125,7 @@ public class MSQControllerTask extends AbstractTask
implements ClientTaskQuery,
@JsonCreator
public MSQControllerTask(
@JsonProperty("id") @Nullable String id,
- @JsonProperty("spec") MSQSpec querySpec,
+ @JsonProperty("spec") LegacyMSQSpec querySpec,
Review Comment:
Since any changes to this class effect backward and forward compatibility
and the changes to the legacy msq spec seem compatible, can we add a test case
here were we take a few json payloads of `old msq spec` and try to convert them
to `legacy msq spec` so that we donot accidentally break backward compatibility
in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
