kfaraz commented on PR #17960: URL: https://github.com/apache/druid/pull/17960#issuecomment-2844228946
> The main purpose is to be able to identify whether a segment is backed by a table or not, which seems like might be better if we just return null for getId(), non-table segment should not have a valid SegmentId. I opened a new PR to implement it: https://github.com/apache/druid/pull/17960. This PR is therefore deprecated. @cecemei , another more obvious way to achieve this would be to simply add a new boolean method `isBackedByTable()` or something to the `Segment` interface. I am not sure if you have already evaluated that option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
