cecemei commented on code in PR #17960:
URL: https://github.com/apache/druid/pull/17960#discussion_r2070573353
##########
processing/src/main/java/org/apache/druid/query/lookup/LookupSegment.java:
##########
@@ -44,10 +43,9 @@ public class LookupSegment extends
RowBasedSegment<Map.Entry<String, String>>
.add(LookupColumnSelectorFactory.VALUE_COLUMN,
ColumnType.STRING)
.build();
- public LookupSegment(final String lookupName, final LookupExtractorFactory
lookupExtractorFactory)
+ public LookupSegment(final LookupExtractorFactory lookupExtractorFactory)
Review Comment:
updated to keep lookupName and return it in `asString`
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/input/ParseExceptionUtils.java:
##########
@@ -47,14 +44,9 @@ public static String
generateReadableInputSourceNameFromMappedSegment(Segment se
"external input source: %s",
((ExternalSegment) segment).externalInputSource().toString()
);
- } else if (segment instanceof LookupSegment) {
- return StringUtils.format("lookup input source: %s",
segment.getId().getDataSource());
Review Comment:
updated this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
