gianm commented on issue #6993: [Proposal] Dynamic prioritization and laning
URL: 
https://github.com/apache/incubator-druid/issues/6993#issuecomment-467219124
 
 
   I think we could, but it should be a different proposal. Even in an async 
http world, we still need some kind of limits on how many concurrent queries 
can be accepted simultaneously, since each one does need to allocate per-query 
memory for merging / etc and there is not an infinite supply. So the stuff in 
this proposal would still be useful, since we still wouldn't want to start an 
unlimited number of queries running at the same time.
   
   I think the main thing I'd change about this proposal if async http existed 
is that instead of going straight to returning HTTP 429 when 
`maxLowPriorityThreads` queries are running, I would instead queue them up but 
delay them starting for a while. We will still need to reject at some point, 
but it'd be later. I'd probably also call the config `maxLowPriorityQueries` 
rather than `maxLowPriorityThreads`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to