clintropolis commented on a change in pull request #7116: segment metadata
fallback analysis if no bitmaps
URL: https://github.com/apache/incubator-druid/pull/7116#discussion_r260062742
##########
File path: processing/src/test/java/org/apache/druid/segment/TestIndex.java
##########
@@ -175,6 +196,17 @@ public static IncrementalIndex
getNoRollupIncrementalTestIndex()
return noRollupRealtimeIndex =
makeRealtimeIndex("druid.sample.numeric.tsv", false);
}
+ public static IncrementalIndex getNoBitmapIncrementalTestIndex()
+ {
+ synchronized (log) {
+ if (noBitmapRealtimeIndex != null) {
+ return noBitmapRealtimeIndex;
+ }
+ }
Review comment:
Updated to use `Suppliers.memoize` instead. I looked into it, and this code
is quite old! It appears to be from the [PR that added timeseries queries to
Druid!](https://github.com/apache/incubator-druid/commit/499263386caed48a42fa26c72582fc97f0e64cb9#diff-1bfae2e7948227908d76a8a385844997R199)
Thanks for review :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
