clintropolis commented on a change in pull request #7116: segment metadata
fallback analysis if no bitmaps
URL: https://github.com/apache/incubator-druid/pull/7116#discussion_r258749732
##########
File path:
processing/src/test/java/org/apache/druid/query/metadata/SegmentMetadataQueryTest.java
##########
@@ -83,10 +83,15 @@
public static QueryRunner makeMMappedQueryRunner(
SegmentId segmentId,
boolean rollup,
+ boolean bitmaps,
QueryRunnerFactory factory
)
{
- QueryableIndex index = rollup ? TestIndex.getMMappedTestIndex() :
TestIndex.getNoRollupMMappedTestIndex();
+ QueryableIndex index = bitmaps
+ ? rollup
Review comment:
I know, these tests were already painful to slip in a test for this since
parameterized, will see if I can clean up. Maybe removing size will help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
