clintropolis opened a new pull request, #18054: URL: https://github.com/apache/druid/pull/18054
### Description Follow-up to #18005, this PR changes `ServerManager` to acquire segment references in bulk before building query runners instead of lazily during the processing of the segment. I think that this should also help reduce the chance for segments to be dropped before being processed since grabbing the reference for each segment is not dependent on when that segments runner runs, in exchange for holding the reference a bit longer. `ReferenceCountingSegmentQueryRunner` is no longer needed and has been deleted. Also did some minor code cleanup in `SegmentManager` to tidy things up (no logic changes). <hr> This PR has: - [ ] been self-reviewed. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
