gianm commented on code in PR #18052:
URL: https://github.com/apache/druid/pull/18052#discussion_r2116893154
##########
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/db/cache/CoordinatorPollingBasicAuthenticatorCacheManager.java:
##########
@@ -126,6 +126,9 @@ public void start()
}
LOG.debug("Scheduled user cache poll is done");
}
+ catch (InterruptedException e) {
+ LOG.noStackTrace().warn(e, "Interrupted while polling
Coordinator for cachedUserMaps.");
Review Comment:
Generally, I like omitting the stack trace for `InterruptedException`, since
it generally happens when a service is being shut down. It's annoying for a
service to log a ton of stack traces when shutting down.
Actually, I would also drop this (& other log messages about interruption)
to `INFO` rather than `WARN`. Interruption here is expected behavior during a
shutdown, nothing bad is happening, so it shouldn't warn.
##########
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/db/cache/CoordinatorPollingBasicAuthenticatorCacheManager.java:
##########
@@ -126,6 +126,9 @@ public void start()
}
LOG.debug("Scheduled user cache poll is done");
}
+ catch (InterruptedException e) {
+ LOG.noStackTrace().warn(e, "Interrupted while polling
Coordinator for cachedUserMaps.");
Review Comment:
Generally, I like omitting the stack trace for `InterruptedException`, since
it generally happens when a service is being shut down. It's annoying for a
service to log a ton of stack traces when shutting down.
Actually, I would also drop this (& other log messages about interruption)
to `INFO` rather than `WARN`. Interruption is expected behavior during a
shutdown, nothing bad is happening, so it shouldn't warn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
