kfaraz commented on code in PR #18052:
URL: https://github.com/apache/druid/pull/18052#discussion_r2117381889
##########
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/db/cache/CoordinatorPollingBasicAuthenticatorCacheManager.java:
##########
@@ -126,6 +126,9 @@ public void start()
}
LOG.debug("Scheduled user cache poll is done");
}
+ catch (InterruptedException e) {
+ LOG.noStackTrace().warn(e, "Interrupted while polling
Coordinator for cachedUserMaps.");
Review Comment:
Thanks for the clarification, @gianm .
I have update the code accordingly, also made the following changes:
- Add a couple of tests to fix the coverage and verify the new behaviour
- Do not retry on `InterruptedException`
- Do not alert on `InterruptedException` in polling methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
