kfaraz commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2127857393
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorReportPayload.java:
##########
@@ -102,6 +105,12 @@ public void addTask(TaskReportData data)
}
}
+ @JsonProperty
+ public String getId()
Review Comment:
Not doing a full review yet since the PR is still in draft.
Just a drive-by comment:
Since we are adding a new ID field anyway, this should live at the top level
in the supervisor spec next to fields `type`, `spec`. It shouldn't be nested
inside the ingestion spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
