jtuglu-netflix commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2138271236
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java:
##########
@@ -313,17 +313,27 @@ tableName, getPayloadType(), getQuoteString(),
getCollation()
public void createDataSourceTable(final String tableName)
{
+ final List<String> columns = new ArrayList<>();
Review Comment:
> There should be an ALTER path for existing clusters where this metadata
table already exists
👍
> supervisor_id will be null for old entries. The PRIMARY KEY will fail for
this case.
Can we make it so we just ADD column as a copy of datasource? I feel like
this will make the metadata querying logic easier. Since that way, for a given
`supervisorId` you don't need to do:
- `supervisor_id` = `supervisorId`
- OR `datasource` = `supervisorId` and `supervisor_id` is NULL
when operating on metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
