gianm commented on code in PR #18084:
URL: https://github.com/apache/druid/pull/18084#discussion_r2131547686
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/MultiValueStringOperatorConversions.java:
##########
@@ -169,9 +168,9 @@ public SqlOperator calciteOperator()
}
@Override
- protected String getFilterExpression(List<DruidExpression>
druidExpressions)
+ public String getDruidFunctionName()
Review Comment:
The main reason for extending `ArrayContainsOperatorConversion` is to get
the filter conversion behavior. This patch doesn't change whether
`ArrayContainsElementFilter` could fire for `MV_CONTAINS`, but just to be safe,
I added a check for this. (If the operator is not `ARRAY_CONTAINS` then it
skips the array-element-filter block.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
