clintropolis commented on code in PR #18084:
URL: https://github.com/apache/druid/pull/18084#discussion_r2131678226
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/MultiValueStringOperatorConversions.java:
##########
@@ -403,14 +402,12 @@ public DruidExpression toDruidExpression(
plannerContext,
rowSignature,
rexNode,
- druidExpressions -> {
- final List<DruidExpression> newArgs =
harmonizeNullsMvdArg0OperandList(druidExpressions);
- return DruidExpression.ofFunctionCall(
- Calcites.getColumnTypeForRelDataType(rexNode.getType()),
- getDruidFunctionName(),
- newArgs
- );
- }
+ druidExpressions ->
Review Comment:
ah, sorry for confusion, i meant of the entire `toDruidExpression ` method
override can be dropped i think, since this is effectively the same as
`DirectOperatorConversion` implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
