abhishekrb19 commented on code in PR #18064:
URL: https://github.com/apache/druid/pull/18064#discussion_r2136150693


##########
server/src/test/java/org/apache/druid/query/lookup/LookupReferencesManagerTest.java:
##########
@@ -849,6 +849,26 @@ public void testCoordinatorLoadSubsetOfLookups() throws 
Exception
     Assert.assertFalse(lookupReferencesManager.get("testLookup3").isPresent());
   }
 
+  @Test
+  public void testAddWithLoadingSpec() throws Exception
+  {
+    LookupLoadingSpec loadingSpec = 
LookupLoadingSpec.loadOnly(ImmutableSet.of("testLookup1"));
+    getLookupMapForSelectiveLoadingOfLookups(loadingSpec);
+
+    LookupExtractorFactoryContainer container2 = new 
LookupExtractorFactoryContainer(

Review Comment:
   Since this bug was observed in the Kafka task scenario, I wonder if it's 
possible to add a test directly in the Kafka indexing module? Not sure if there 
are existing UTs/ITs that use lookups, but if it's too much trouble, I think 
this unit test should be good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to