abhishekrb19 commented on code in PR #18064:
URL: https://github.com/apache/druid/pull/18064#discussion_r2122586418
##########
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java:
##########
@@ -282,6 +282,13 @@ public void stop()
public void add(String lookupName, LookupExtractorFactoryContainer
lookupExtractorFactoryContainer)
{
Preconditions.checkState(lifecycleLock.awaitStarted(1,
TimeUnit.MILLISECONDS));
+ LookupLoadingSpec lookupLoadingSpec =
lookupListeningAnnouncerConfig.getLookupLoadingSpec();
+ if (lookupLoadingSpec.getMode() == LookupLoadingSpec.Mode.NONE ||
+ (lookupLoadingSpec.getMode() == LookupLoadingSpec.Mode.ONLY_REQUIRED
+ && !lookupLoadingSpec.getLookupsToLoad().contains(lookupName))) {
+ LOG.warn("Skipping notice to add lookup [%s] : current lookup loading
mode does not allow it.", lookupName);
+ return;
Review Comment:
I think the `SeekableStreamIndexTask` should populate the task
[context](https://github.com/apache/druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTask.java#L103)
from the context map similar to how a few other task types do. Then the change
in the lookup manager may not be necessary since the lookup spec would already
have been materialized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
