vtlim commented on code in PR #18027: URL: https://github.com/apache/druid/pull/18027#discussion_r2138488654
########## docs/api-reference/sql-ingestion-api.md: ########## @@ -100,23 +100,22 @@ The `/druid/v2/sql/task` endpoint accepts the following: ### Sample request -The following example shows a query that fetches data from an external JSON source and inserts it into a table named `wikipedia`. +The following example shows a query that fetches data from an external JSON source and inserts it into a table named `wikipedia`. It specifies two query context parameters: Review Comment: ```suggestion The following example shows a query that fetches data from an external JSON source and inserts it into a table named `wikipedia`. The example specifies two query context parameters: ``` ########## docs/api-reference/sql-api.md: ########## @@ -188,7 +188,12 @@ If you detect a truncated response, treat it as an error. #### Sample request -The following example retrieves all rows in the `wikipedia` datasource where the `user` is `BlueMoon2662`. The query is assigned the ID `request01` using the `sqlQueryId` context parameter. The optional properties `header`, `typesHeader`, and `sqlTypesHeader` are set to `true` to include type information to the response. +This sample request demonstrates the following actions: Review Comment: ```suggestion In the following example, this query demonstrates the following actions: ``` ########## docs/querying/using-caching.md: ########## @@ -83,8 +83,12 @@ As long as the service is set to populate the cache, you can set cache options f } } ``` + In this example the user has set `populateCache` to `false` to avoid filling the result cache with results for segments that are over a year old. For more information, see [Druid SQL client APIs](../api-reference/sql-api.md). +You can also use the SET command to specify cache options directly within your SQL query string. For details about SET, see [SET statements](../querying/sql.md#set). Review Comment: ```suggestion You can also use the SET command to specify cache options directly within your SQL query string. For more information, see [SET statements](../querying/sql.md#set-statements). ``` ########## docs/querying/query-from-deep-storage.md: ########## Review Comment: Discard changes to this file since we won't document the limitation since it'll be fixed ########## docs/api-reference/sql-api.md: ########## @@ -188,7 +188,12 @@ If you detect a truncated response, treat it as an error. #### Sample request -The following example retrieves all rows in the `wikipedia` datasource where the `user` is `BlueMoon2662`. The query is assigned the ID `request01` using the `sqlQueryId` context parameter. The optional properties `header`, `typesHeader`, and `sqlTypesHeader` are set to `true` to include type information to the response. +This sample request demonstrates the following actions: +- This query retrieves all rows from the `wikipedia` datasource. +- This query also filters the results where the `user` value is `BlueMoon2662`. +- The `sqlTimeZone` context parameter sets the time zone to `America/Los_Angeles` for query results. +- The query results also include descriptors for `header`, `typesHeader`, and `sqlTypesHeader`. Review Comment: ```suggestion - Retrieves all rows from the `wikipedia` datasource. - Filters the results where the `user` value is `BlueMoon2662`. - Applies the `sqlTimeZone` context parameter to set the time zone of results to `America/Los_Angeles`. - Returns descriptors for `header`, `typesHeader`, and `sqlTypesHeader`. ``` ########## docs/api-reference/sql-ingestion-api.md: ########## @@ -100,23 +100,22 @@ The `/druid/v2/sql/task` endpoint accepts the following: ### Sample request -The following example shows a query that fetches data from an external JSON source and inserts it into a table named `wikipedia`. +The following example shows a query that fetches data from an external JSON source and inserts it into a table named `wikipedia`. It specifies two query context parameters: +- `maxNumTasks=3`: This limits the maximum number of parallel tasks to 3. +- `finalizeAggregations=false`: This prevents Druid from performing final data aggregation during loading. It's useful if you want to work with intermediate data states or control aggregation later. For more information, see [Rollup](../multi-stage-query/concepts/#rollup). Review Comment: ```suggestion - `maxNumTasks=3`: Limits the maximum number of parallel tasks to 3. - `finalizeAggregations=false`: Prevents Druid from performing final data aggregation during loading. It's useful if you want to work with intermediate data states or control aggregation later. For more information, see [Rollup](../multi-stage-query/concepts.md#rollup). ``` ########## docs/multi-stage-query/reference.md: ########## @@ -127,6 +128,10 @@ SELECT FROM <table> ``` +When the number of rows in the result set exceeds the value of the parameter, Druid splits the output into multiple files. Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
