github-advanced-security[bot] commented on code in PR #18136:
URL: https://github.com/apache/druid/pull/18136#discussion_r2142020911
##########
server/src/test/java/org/apache/druid/client/selector/TierSelectorStrategyTest.java:
##########
@@ -260,17 +261,214 @@
servers.add(p0);
RandomServerSelectorStrategy strategy = new RandomServerSelectorStrategy();
Assert.assertEquals(strategy.pick(servers,
EasyMock.createMock(DataSegment.class)), p0);
- Assert.assertEquals(strategy.pick(EasyMock.createMock(Query.class),
servers, EasyMock.createMock(DataSegment.class)), p0);
- ServerSelectorStrategy defaultDeprecatedServerSelectorStrategy = new
ServerSelectorStrategy() {
+ Assert.assertEquals(
+ strategy.pick(
+ EasyMock.createMock(Query.class),
+ servers,
+ EasyMock.createMock(DataSegment.class)
+ ), p0
+ );
+ ServerSelectorStrategy defaultDeprecatedServerSelectorStrategy = new
ServerSelectorStrategy()
+ {
@Override
- public <T> List<QueryableDruidServer> pick(@Nullable Query<T> query,
Set<QueryableDruidServer> servers, DataSegment segment,
- int numServersToPick)
+ public <T> List<QueryableDruidServer> pick(
+ @Nullable Query<T> query, Collection<QueryableDruidServer> servers,
DataSegment segment,
+ int numServersToPick
+ )
{
return strategy.pick(servers, segment, numServersToPick);
}
};
- Assert.assertEquals(defaultDeprecatedServerSelectorStrategy.pick(servers,
EasyMock.createMock(DataSegment.class)), p0);
- Assert.assertEquals(defaultDeprecatedServerSelectorStrategy.pick(servers,
EasyMock.createMock(DataSegment.class), 1).get(0), p0);
+ Assert.assertEquals(
+ defaultDeprecatedServerSelectorStrategy.pick(servers,
EasyMock.createMock(DataSegment.class)),
Review Comment:
## Deprecated method or constructor invocation
Invoking [ServerSelectorStrategy.pick](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/9231)
##########
server/src/main/java/org/apache/druid/client/selector/ServerSelectorStrategy.java:
##########
@@ -38,26 +39,26 @@
public interface ServerSelectorStrategy
{
@Nullable
- default <T> QueryableDruidServer pick(@Nullable Query<T> query,
Set<QueryableDruidServer> servers, DataSegment segment)
+ default <T> QueryableDruidServer pick(@Nullable Query<T> query,
Collection<QueryableDruidServer> servers, DataSegment segment)
{
return Iterables.getOnlyElement(pick(query, servers, segment, 1), null);
}
- default <T> List<QueryableDruidServer> pick(@Nullable Query<T> query,
Set<QueryableDruidServer> servers, DataSegment segment,
+ default <T> List<QueryableDruidServer> pick(@Nullable Query<T> query,
Collection<QueryableDruidServer> servers, DataSegment segment,
Review Comment:
## Useless parameter
The parameter 'query' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/9233)
##########
server/src/test/java/org/apache/druid/client/selector/TierSelectorStrategyTest.java:
##########
@@ -260,17 +261,214 @@
servers.add(p0);
RandomServerSelectorStrategy strategy = new RandomServerSelectorStrategy();
Assert.assertEquals(strategy.pick(servers,
EasyMock.createMock(DataSegment.class)), p0);
- Assert.assertEquals(strategy.pick(EasyMock.createMock(Query.class),
servers, EasyMock.createMock(DataSegment.class)), p0);
- ServerSelectorStrategy defaultDeprecatedServerSelectorStrategy = new
ServerSelectorStrategy() {
+ Assert.assertEquals(
+ strategy.pick(
+ EasyMock.createMock(Query.class),
+ servers,
+ EasyMock.createMock(DataSegment.class)
+ ), p0
+ );
+ ServerSelectorStrategy defaultDeprecatedServerSelectorStrategy = new
ServerSelectorStrategy()
+ {
@Override
- public <T> List<QueryableDruidServer> pick(@Nullable Query<T> query,
Set<QueryableDruidServer> servers, DataSegment segment,
- int numServersToPick)
+ public <T> List<QueryableDruidServer> pick(
+ @Nullable Query<T> query, Collection<QueryableDruidServer> servers,
DataSegment segment,
+ int numServersToPick
+ )
{
return strategy.pick(servers, segment, numServersToPick);
}
};
- Assert.assertEquals(defaultDeprecatedServerSelectorStrategy.pick(servers,
EasyMock.createMock(DataSegment.class)), p0);
- Assert.assertEquals(defaultDeprecatedServerSelectorStrategy.pick(servers,
EasyMock.createMock(DataSegment.class), 1).get(0), p0);
+ Assert.assertEquals(
+ defaultDeprecatedServerSelectorStrategy.pick(servers,
EasyMock.createMock(DataSegment.class)),
+ p0
+ );
+ Assert.assertEquals(
+ defaultDeprecatedServerSelectorStrategy.pick(servers,
EasyMock.createMock(DataSegment.class), 1)
Review Comment:
## Deprecated method or constructor invocation
Invoking [ServerSelectorStrategy.pick](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/9232)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
