FrankChen021 commented on code in PR #18136:
URL: https://github.com/apache/druid/pull/18136#discussion_r2176353750
##########
server/src/main/java/org/apache/druid/client/selector/ServerSelectorStrategy.java:
##########
@@ -38,26 +38,26 @@
public interface ServerSelectorStrategy
{
@Nullable
- default <T> QueryableDruidServer pick(@Nullable Query<T> query,
Set<QueryableDruidServer> servers, DataSegment segment)
+ default <T> QueryableDruidServer pick(@Nullable Query<T> query,
Collection<QueryableDruidServer> servers, DataSegment segment)
Review Comment:
in the `PreferredTierSelectorStrategy.pick`, a List is used to save
candidate servers. So the `Set` here needs to be changed to `Collection` so
that both `List` and original `Set` work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
