kgyrtkirk commented on code in PR #18075:
URL: https://github.com/apache/druid/pull/18075#discussion_r2142018331
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ProcessingBuffersProvider.java:
##########
@@ -32,7 +32,7 @@ public interface ProcessingBuffersProvider
/**
* Acquire buffers for a {@link Worker}.
*/
- ResourceHolder<ProcessingBuffersSet> acquire(int poolSize);
+ ResourceHolder<ProcessingBuffersSet> acquire(int poolSize, long
timeoutMillis);
Review Comment:
note: I think the usage of `Duration` would be usefull
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ProcessingBuffersSet.java:
##########
@@ -59,13 +59,25 @@ public static <T extends Collection<ByteBuffer>>
ProcessingBuffersSet fromCollec
);
}
+ /**
+ * Acquire buffers if a particular stages needs them; otherwise, returns
null.
+ */
Review Comment:
note: instead of this apidoc + `@Nullable` annotations and the `if`-s
handling the null: it would be usefull to return a `ResourceHolder` which's
`get` throws the exception that there is no buffer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
