gianm commented on code in PR #18075:
URL: https://github.com/apache/druid/pull/18075#discussion_r2143289045
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ProcessingBuffersSet.java:
##########
@@ -59,13 +59,25 @@ public static <T extends Collection<ByteBuffer>>
ProcessingBuffersSet fromCollec
);
}
+ /**
+ * Acquire buffers if a particular stages needs them; otherwise, returns
null.
+ */
Review Comment:
Fair enough, I made this change.
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ProcessingBuffersProvider.java:
##########
@@ -32,7 +32,7 @@ public interface ProcessingBuffersProvider
/**
* Acquire buffers for a {@link Worker}.
*/
- ResourceHolder<ProcessingBuffersSet> acquire(int poolSize);
+ ResourceHolder<ProcessingBuffersSet> acquire(int poolSize, long
timeoutMillis);
Review Comment:
IMO a `long` makes sense because there's only one call site, and it passes
`queryDef.getContext().getTimeout()` which is a long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
