kgyrtkirk commented on PR #18127: URL: https://github.com/apache/druid/pull/18127#issuecomment-2969821283
it did sucked up the dispersing complexity I didn't liked that much - I still see a `LocalX` classes more usefull; they could for sure eat up more real estate on our screens - but they appear as 1st class citizens in the stack traces and debugging something like `filterMatchers.stream().anyMatch(m -> m.matches(f))` is pretty inconvinient ; this might be just my own preferrence; in this case it for sure doesn't matter at all :D thank you for the changes! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
