FrankChen021 commented on PR #18087:
URL: https://github.com/apache/druid/pull/18087#issuecomment-2969967401
> @gianm please take a look at the proposed change first. All String based
query context parameters in the QueryContexts will be changed to the new
`SettingEntry<T>`. I changed two params, `FINALIZE_KEY` and
`USE_RESULT_LEVEL_CACHE_KEY` to demonstrate how to use the new API and how
these two are used/referenced in other classes.
>
> One thing I'm still considering is that is there a way to eliminate so
many getter functions defined in QueryContext to keep the code simple and clean.
>
> for example:
>
> ```java
> public boolean isSerializeDateTimeAsLong(boolean defaultValue)
> {
> return getBoolean(QueryContexts.SERIALIZE_DATE_TIME_AS_LONG_KEY,
defaultValue);
> }
> ```
>
> can the reference of `queryContext.isSerializeDateTimeAsLong(true)` be
simplified to sth like `queryContext.SERIALIZE_DATE_TIME_AS_LONG_KEY.get()`?
For this part, please refer to the `isFinalize` in the `QueryContext` to see
how it's defined and used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
