jtuglu-netflix commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2152762773
##########
server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java:
##########
@@ -100,6 +100,7 @@
@RunWith(Parameterized.class)
public class IndexerSQLMetadataStorageCoordinatorTest extends
IndexerSqlMetadataStorageCoordinatorTestBase
{
+ private static final String SUPERVISOR_ID = "supervisor";
Review Comment:
`supervisorId` should never be null AFAIK at this stage (if it's needed). It
defaults to `dataSource` elsewhere in the code. We do verifications to ensure
that supervisorId and start/end metadata are both non-null (where necessary).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
