jtuglu-netflix commented on code in PR #18082: URL: https://github.com/apache/druid/pull/18082#discussion_r2152764583
########## docs/ingestion/supervisor.md: ########## @@ -37,11 +37,13 @@ The following table outlines the high-level configuration options for a supervis |Property|Type|Description|Required| |--------|----|-----------|--------| +|`id`|String|The supervisor id. This should be a unique ID that will identify the supervisor.|Yes| |`type`|String|The supervisor type. For streaming ingestion, this can be either `kafka`, `kinesis`, or `rabbit`. For automatic compaction, set the type to `autocompact`. |Yes| Review Comment: Yes, I noticed this – I was going to do the web-related changes in a separate PR. ########## docs/ingestion/supervisor.md: ########## @@ -37,11 +37,13 @@ The following table outlines the high-level configuration options for a supervis |Property|Type|Description|Required| |--------|----|-----------|--------| +|`id`|String|The supervisor id. This should be a unique ID that will identify the supervisor.|Yes| |`type`|String|The supervisor type. For streaming ingestion, this can be either `kafka`, `kinesis`, or `rabbit`. For automatic compaction, set the type to `autocompact`. |Yes| |`spec`|Object|The container object for the supervisor configuration. For automatic compaction, this is the same as the compaction configuration. |Yes| Review Comment: Yes, I noticed this – I was going to do the web-related changes in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
