kgyrtkirk commented on code in PR #18147: URL: https://github.com/apache/druid/pull/18147#discussion_r2154201470
########## simulation-tests/src/test/java/org/apache/druid/testing/simulate/embedded/DruidServerJunitResource.java: ########## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testing.simulate.embedded; + +import com.google.common.base.Throwables; +import com.google.inject.Injector; +import com.google.inject.Module; +import org.apache.druid.cli.ServerRunnable; +import org.apache.druid.guice.StartupInjectorBuilder; +import org.apache.druid.java.util.common.concurrent.Execs; +import org.apache.druid.java.util.common.lifecycle.Lifecycle; +import org.apache.druid.java.util.common.logger.Logger; +import org.apache.druid.metadata.TestDerbyConnector; +import org.apache.druid.utils.JvmUtils; +import org.apache.druid.utils.RuntimeInfo; +import org.junit.rules.ExternalResource; Review Comment: junit5 could give finer control than `ExternalResource` ( look at the subclasses of `org.junit.jupiter.api.extension.Extension.class`) and it handles some things much better than 4. fyi: there is already `TestDerbyConnector$DerbyConnectorRule5` - I've added it when I needed it earlier. > independent of the JUnit version sure; might make sense - but I think we should only write new tests in junit5; test writers could have much better control over things when its needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
